[ https://issues.apache.org/jira/browse/HADOOP-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated HADOOP-5721: ------------------------------------------- Attachment: HADOOP-5721.patch Submitting a new patch that fixes the issues pointed out by Konstantin. Please note that I have made a couple of small modifications to sizeFlushBuffer. I think they make its use cleaner, and I don't think it breaks anything, but please verify. Here are the modifications and my rationale. First, I have made it a constant because I don't think we should be modifying that value during an execution of the namenode. Second, as we only need the size of the buffer when constructing a new EditLogFileOutputStream, if we need to have a different buffer size, then we could simply pass the new size as a parameter of the constructor. So, I have added a simple constructor that takes a second parameter, which is the buffer size. This way we can change the size of the buffer, and yet have a default value. > Provide EditLogFileInputStream and EditLogFileOutputStream as independent > classes > ---------------------------------------------------------------------------------- > > Key: HADOOP-5721 > URL: https://issues.apache.org/jira/browse/HADOOP-5721 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Affects Versions: 0.19.1 > Reporter: Luca Telloli > Priority: Minor > Fix For: 0.21.0 > > Attachments: HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch, > HADOOP-5721.patch > > > EditLogFileInputStream and EditLogFileOutputStream are currently part of > FSEditLog. With this patch we want to extract them and provide as independent > classes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.