[ https://issues.apache.org/jira/browse/HADOOP-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702831#action_12702831 ]
Hadoop QA commented on HADOOP-5730: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12406238/secondarynamenode-startcp.patch against trunk revision 768376. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/243/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/243/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/243/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/243/console This message is automatically generated. > SecondaryNameNode: should not throw exception and exit if only one makedir > failure > ----------------------------------------------------------------------------------- > > Key: HADOOP-5730 > URL: https://issues.apache.org/jira/browse/HADOOP-5730 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Affects Versions: 0.19.1 > Reporter: Wang Xu > Assignee: Wang Xu > Fix For: 0.19.2 > > Attachments: secondarynamenode-startcp.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > In CheckpointStorage.startCheckPointing(), if one mkdir failed, it > will throw an exception and exit. > However, because the editlog has been closed before, the editStreams > of FSEditLog of NameNode will becomes empty as a result, which > will affect any further logSync operations. > Hence we think it should only print WARN message instead of > throw the exception -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.