[
https://issues.apache.org/jira/browse/HADOOP-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703571#action_12703571
]
Sharad Agarwal commented on HADOOP-5720:
----------------------------------------
Had a look at the patch:
1. I think we can remove isMap() from TaskID, because anyway this is going to
be an incompatible change as public constructors in TaskID and TaskAttemptID
have got changed.
2. CharTaskTypes need not be a top level class. Its functionality is pretty
much limited to TaskID. We can move it inside TaskID and make it as private.
3. TaskID#getTaskIDsPattern has "(m|r|s|c|t)". This should be constructed from
CharTaskTypes. Or otherwise we just remove TaskID#getTaskIDsPattern as it is
deprecated.
4. version should be updated in protocols as TaskID serialization has changed.
5. minor nit : comment in TaskType should be updated to reflect all types of
tasks.
> Create enum for the TaskTypes (Map, Reduce, JobSetup, JobCleanup, TaskCleanup)
> ------------------------------------------------------------------------------
>
> Key: HADOOP-5720
> URL: https://issues.apache.org/jira/browse/HADOOP-5720
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.21.0
>
> Attachments: 5720.1.patch
>
>
> Create enum for the TaskTypes - Map, Reduce, JobSetup, JobCleanup,
> TaskCleanup. Change the framework to use these enum constants and remove
> usages of booleans like isMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
