[
https://issues.apache.org/jira/browse/HADOOP-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704324#action_12704324
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5711:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{noformat}
The change is trivial. Don't want to waste cycles in Hudson. Will commit it
soon.
> Change Namenode file close log to info
> --------------------------------------
>
> Key: HADOOP-5711
> URL: https://issues.apache.org/jira/browse/HADOOP-5711
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 5711_20090422.patch, 5711_20090428.patch
>
>
> It is hard to tell whether a file is closed or not from the Namenode log if
> the stateChangeLog is not set to debug level. It is better to log file close
> in info level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
