[
https://issues.apache.org/jira/browse/HADOOP-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
He Yongqiang updated HADOOP-5596:
---------------------------------
Attachment: Hadoop-5596-2009-04-30.patch
Thanks, Nicholas.
>>enforce the status that either both elementType and value are null, or both
>>are not null.
We now enforce if value is empty or null, elementType must provided.
>>check null before accessing value in equals(..), hashCode(), toString(), etc.
>>Otherwise, there are NPE.
done.
>>check null for conf.
did it in ObjectWritable's loadClass.
>>usage of @SuppressWarnings("unchecked")
All the Warnings now are caused by ObjectWritable.
pls take a look at the new patch file, if ok, i will submit it for patch
testing.
> Make ObjectWritable support EnumSet
> -----------------------------------
>
> Key: HADOOP-5596
> URL: https://issues.apache.org/jira/browse/HADOOP-5596
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: Hadoop-5596-2009-03-31.patch,
> Hadoop-5596-2009-04-03.patch, Hadoop-5596-2009-04-15-2.patch,
> Hadoop-5596-2009-04-15.patch, Hadoop-5596-2009-04-24.patch,
> Hadoop-5596-2009-04-30.patch
>
>
> This is a demand for Hadoop-5438.
> Also another small improvement is that i saw that in the beginning of
> readObject, it tries to get the class from PRIMITIVE_NAMES and then conf.
> Maybe it is better to add a direct load after them if the delaredClass is
> still null. Like this:
> {code}
> String className = UTF8.readString(in);
> Class<?> declaredClass = PRIMITIVE_NAMES.get(className);
> if (declaredClass == null) {
> try {
> declaredClass = conf.getClassByName(className);
> } catch (Exception e) {
> }
> }
>
> if(declaredClass == null) {
> try {
> declaredClass = Class.forName(className);
> } catch (ClassNotFoundException e) {
> throw new RuntimeException("readObject can't find class " +
> className, e);
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
