[
https://issues.apache.org/jira/browse/HADOOP-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705493#action_12705493
]
Chris Douglas commented on HADOOP-5733:
---------------------------------------
Looks good
For the map/reduce slots:
* Instead of \{add,dec\}\*Slots, consider adding set\*Slots to the
instrumentation and update with total\*TaskCapacity (use
MetricsRecord::setMetric)
* Updates can occur outside the synchronized block in addHostCapacity and
removeHostCapacity. With get/set, the field in the metrics can be volatile and
updated without synchronizing on the instrumentation
For the blacklisted slots:
* The add/dec methods should be synchronized; there's a race condition with
doUpdate
> Add map/reduce slot capacity and lost map/reduce slot capacity to JobTracker
> metrics
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5733
> URL: https://issues.apache.org/jira/browse/HADOOP-5733
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred, metrics
> Reporter: Hong Tang
> Attachments: hadoop-5733-1.patch
>
>
> It would be nice to have the actual map/reduce slot capacity and the lost
> map/reduce slot capacity (# of blacklisted nodes * map-slot-per-node or
> reduce-slot-per-node). This information can be used to calculate a JT view of
> slot utilization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
