[
https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705554#action_12705554
]
Jothi Padmanabhan commented on HADOOP-5081:
-------------------------------------------
Some minor comments
# CommandExecutor.execute should ideally return a Results object instead of
returning the executor itself
# There are quite a few assert statements that basically are no-ops as the
condition would always return as true
# Remove unused import in TestCLI.java
# Remove the comment "// Start up mini mr cluster" in TestCLI.setup
> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
> Key: HADOOP-5081
> URL: https://issues.apache.org/jira/browse/HADOOP-5081
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.0
> Reporter: Ramya R
> Assignee: Sharad Agarwal
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5081_v1.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred.
> Going forward, this test has to be broken up into separate hdfs, mapred and
> core tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
