[ 
https://issues.apache.org/jira/browse/HADOOP-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708237#action_12708237
 ] 

Rodrigo Schmidt commented on HADOOP-5762:
-----------------------------------------

It could be done. Actually, my first attempt to fix this bug did exactly that. 
Then I noticed that method copy() was already programmed to copy empty 
directories and, except for the root source, directories were being added to 
src_writer on method setup. I think it's a good design option to let copy be 
the only method that actually writes something to the destination. This makes 
the code simpler and more elegant (thus, more maintainable).

I'm don't like the idea of creating only the root src directory (in case it's 
empty) on setup(). It just doesn't look good. And creating all empty src 
subdirectories on setup might force us to do a lot of extra checking on setup 
to cope with failures (checks that already exist on copy()). I don't think many 
people will be using distcp to copy empty directories and it doesn't look like 
the performance gain will compensate the loss in code simplicity.

> distcp does not copy empty directories
> --------------------------------------
>
>                 Key: HADOOP-5762
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5762
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: dhruba borthakur
>            Assignee: Rodrigo Schmidt
>             Fix For: site
>
>         Attachments: HADOOP-5762.patch
>
>
> If I have an empty directory /testdir1 and then I run the command bin/hadoop 
> distcp /testdir1 /testdir2, the command completes successfully, but does not 
> create the empty directory /testdir2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to