[
https://issues.apache.org/jira/browse/HADOOP-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708783#action_12708783
]
Jothi Padmanabhan commented on HADOOP-5572:
-------------------------------------------
Looks good. A few more points:
# Create a new method getProgressForCurrentNode() and keep getInternal() private
# addPhases(int) should call existing addPhase method instead of duplicating
code
# Check for (mapFinishTime.length() > 0) is not required in JT
# MapTask: isMapOrReduceTask can use isMapTask()
# Check if progress is being updated correctly and works fine with new Reducer
API
# Merger: Remove Collections.sort() in the beginning
# Can we do better than relying on writesCounter to determine if the final
merge needs to be included in the calculation or not?
> The map progress value should have a separate phase for doing the final sort.
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5572
> URL: https://issues.apache.org/jira/browse/HADOOP-5572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Ravi Gummadi
> Attachments: HADOOP-5572.patch, HADOOP-5572.v1.1.patch,
> HADOOP-5572.v1.patch
>
>
> Currently, the final spill and sort doesn't record any progress while it
> runs, leading to the perception that the map is done, but "stuck".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
