[ 
https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709655#action_12709655
 ] 

Hadoop QA commented on HADOOP-5833:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408122/hadoop-5833.patch
  against trunk revision 774912.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to cause Findbugs to fail.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/testReport/
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/342/console

This message is automatically generated.

> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format 
> Class to SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5833
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.20.0
>            Reporter: Daniel Leffel
>            Priority: Minor
>         Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets 
> the job up appropriately. However, that's not the case for 
> SequenceFileOutputFormat.setOutputPath(Job,Path). This has tripped up more 
> than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path) should 
> call both the superclass method as well as 
> job.setOutputFormatClass(SequenceFileOutputFormat.class);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to