[
https://issues.apache.org/jira/browse/HADOOP-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709766#action_12709766
]
Hemanth Yamijala commented on HADOOP-4981:
------------------------------------------
- Please check for the condition tip.isRunning() before other conditions in
hasSpeculativeTask()
- Don't you need to override the speculation related methods in
FakeTaskInProgress ?
- The high RAM jobs test case isn't still covering the code path for
hasSpeculativeTask. To do that, I guess you need a tasktracker with 2 maps
slots. Please rework the test along those lines.
> Prior code fix in Capacity Scheduler prevents speculative execution in jobs
> ---------------------------------------------------------------------------
>
> Key: HADOOP-4981
> URL: https://issues.apache.org/jira/browse/HADOOP-4981
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Vivek Ratan
> Attachments: 4981.1.patch, 4981.2.patch, HADOOP-4981-1.patch,
> HADOOP-4981-2.patch
>
>
> As part of the code fix for HADOOP-4035, the Capacity Scheduler obtains a
> task from JobInProgress (calling obtainNewMapTask() or obtainNewReduceTask())
> only if the number of pending tasks for a job is greater than zero (see the
> if-block in TaskSchedulingMgr.getTaskFromJob()). So, if a job has no pending
> tasks and only has running tasks, it will never be given a slot, and will
> never have a chance to run a speculative task.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
