[
https://issues.apache.org/jira/browse/HADOOP-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710011#action_12710011
]
Suresh Srinivas commented on HADOOP-5854:
-----------------------------------------
This is a good change. Comments:
# {{isInSafeMode()}} and {{safemode}} access with synchronize(this) surrounding
it, can be moved out of the synchronized block
# {{FSDirectory.waitForReady()}} need not have {{synchronized(this)}}
# Should {{DFSClient.createBlockOutputStream()}} where {{persistBlocks}} is set
to true be synchornized? Not sure how findbugs can ignore this case by just
setting the variable to volatile!
> findbugs : fix "Inconsistent Synchronization" warnings in hdfs
> ---------------------------------------------------------------
>
> Key: HADOOP-5854
> URL: https://issues.apache.org/jira/browse/HADOOP-5854
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5854.patch
>
>
> This jira fixes the following findbugs warnings :
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closed; locked 75% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.persistBlocks; locked 66% of
> time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.common.UpgradeManager.currentUpgrades; locked
> 61% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.common.UpgradeManager.upgradeState; locked 75%
> of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSDirectory.ready; locked 50% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.verificationLog;
> locked 45% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.safeMode; locked 48% of
> time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem$SafeModeInfo.extension;
> locked 80% of time
> * Inconsistent synchronization of
> org.apache.hadoop.io.SequenceFile$Reader.sync; locked 85% of time
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
