[ 
https://issues.apache.org/jira/browse/HADOOP-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710558#action_12710558
 ] 

Todd Lipcon commented on HADOOP-5852:
-------------------------------------

Thanks, Devaraj and Tom.

I agree that passing "this" out of a constructor is bad Java style, but it's 
clearly already done since the IPC handlers are instantiated with a reference 
to the NN object.

Given that this can cause serious issues at startup time, I'd like to target a 
fix for the 18 branch. Any opinions on that? We could either backport the 
"offerService" refactor, or simply leak "this" again as proposed in my option 
#1 above.

> JobTracker accepts heartbeats before startup is complete
> --------------------------------------------------------
>
>                 Key: HADOOP-5852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5852
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>            Priority: Critical
>
> When the JobTracker is instantiated, it starts listening on its RPC 
> interfaces before its startup is complete (ie the constructor is finished 
> executing). Because of this, jt.taskScheduler.taskTrackerManager can be null 
> when the JT receives a heartbeat from a TT. This throws the JT/TT pair into a 
> tight infinite loop (HADOOP-5761)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to