FSDirectory.renameTo(String, String) has unclear logic around 
unprotectedRenameTo() call
----------------------------------------------------------------------------------------

                 Key: HADOOP-5868
                 URL: https://issues.apache.org/jira/browse/HADOOP-5868
             Project: Hadoop Core
          Issue Type: Improvement
          Components: dfs
    Affects Versions: 0.20.0
            Reporter: Konstantin Boudnik
            Assignee: Konstantin Boudnik
            Priority: Minor


Current implementation of renameTo(String, String) has this piece of the code 
at the end:

...
    if (!unprotectedRenameTo(src, dst, now))
      return false;
    fsImage.getEditLog().logRename(src, dst, now);
    return true;
}
The logic of the code isn't very clear from a very sight. A slight modification 
is recommended to make it more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to