[ https://issues.apache.org/jira/browse/HADOOP-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711829#action_12711829 ]
Raghu Angadi commented on HADOOP-5826: -------------------------------------- I think it is better for someone with more familiarity with distcp to review. My comments from a brief look at the patch : - it might throw exception if used like 'distcp -basedir /a/b /a/b /dst' - does simple 'distcp /dir0/dir1 /dst' create /dst/dir1 directory or move contents for dir1 into /dst? If it is former, then test case does not seem to test feature. - The implementation changes the destination path but does not explicitly create the extra directories. Will it satisfy preserving the properties of those directories? (ie. '-basedir /a /a/b/c /dst' may not preserve properties for /dst/b and /dst/b/c). > distcp could have an option to preserve the full source path > ------------------------------------------------------------ > > Key: HADOOP-5826 > URL: https://issues.apache.org/jira/browse/HADOOP-5826 > Project: Hadoop Core > Issue Type: Bug > Components: tools/distcp > Reporter: Rodrigo Schmidt > Assignee: Rodrigo Schmidt > Fix For: 0.21.0 > > Attachments: HADOOP-5826.patch > > > It would be helpful to have an option that preserves the full source path > when copying files from one location to another. This is specially important > when archiving/moving files from one cluster to another one. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.