[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711964#action_12711964 ]
Hadoop QA commented on HADOOP-5864: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408499/findBugs1.patch against trunk revision 777330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 release audit. The applied patch generated 492 release audit warnings (more than the trunk's current 491 warnings). +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/console This message is automatically generated. > Fix fDMI and OBL findbugs in packages hdfs and metrics > ------------------------------------------------------ > > Key: HADOOP-5864 > URL: https://issues.apache.org/jira/browse/HADOOP-5864 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: 0.21.0 > > Attachments: findBugs.patch, findBugs1.patch > > > This issue is to fix the following findbugs: > DMI in > org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], > INode[]) > OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, > File, int) > OBL in > org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, > File) > OBL in > org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, > long, long) > OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes() -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.