[ 
https://issues.apache.org/jira/browse/HADOOP-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712275#action_12712275
 ] 

Kan Zhang commented on HADOOP-5859:
-----------------------------------

added a new patch that refactored DFSClient.DFSOutputStream code.
1) socket write operation in DataStreamer is now done without holding dataQueue 
lock
2) dataQueue lock and ackQueue lock are merged into one
3) removed the above findbugs warnings

> FindBugs : fix "wait() or sleep() with locks held" warnings in hdfs
> -------------------------------------------------------------------
>
>                 Key: HADOOP-5859
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5859
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5859-19.patch, 5859-4.patch, 5859-5.patch, 5859-8.patch
>
>
> This JIRA fixes the following warnings:
> SWL   org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closeInternal() calls 
> Thread.sleep() with a lock held
> TLW   wait() with two locks held in 
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal()
> TLW   wait() with two locks held in 
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal()
> TLW   wait() with two locks held in 
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.writeChunk(byte[], int, int, 
> byte[])

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to