[
https://issues.apache.org/jira/browse/HADOOP-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712654#action_12712654
]
Hadoop QA commented on HADOOP-5890:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408764/hadoop-5890.txt
against trunk revision 778182.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/395/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/395/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/395/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/395/console
This message is automatically generated.
> Use exponential backoff on Thread.sleep during DN shutdown
> ----------------------------------------------------------
>
> Key: HADOOP-5890
> URL: https://issues.apache.org/jira/browse/HADOOP-5890
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-5890.txt
>
>
> Tests waste a lot of time in DataNode.shutdown. Typical logs look like:
> {code}
> 2009-05-21 17:13:20,177 INFO datanode.DataNode (DataNode.java:shutdown(637))
> - Waiting for threadgroup to exit, active threads is 0
> 2009-05-21 17:13:20,177 INFO datanode.DataBlockScanner
> (DataBlockScanner.java:run(620)) - Exiting DataBlockScanner thread.
> 2009-05-21 17:13:21,117 INFO datanode.DataNode (DataNode.java:shutdown(637))
> - Waiting for threadgroup to exit, active threads is 0
> {code}
> In this example (and very commonly) the DataBlockScanner thread exits within
> 5-10ms after the first wait. The DN then sleeps an entire second before
> succeeding in shutting down.
> Using exponential backoff from a short value like 2ms up to a maximum of
> 1000ms would solve this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
