[ https://issues.apache.org/jira/browse/HADOOP-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712897#action_12712897 ]
Chris Douglas commented on HADOOP-5879: --------------------------------------- Sorry, I didn't mean that it would fail or not change the setting. I meant that, since these parameters are specified in the constructor, there's no place where these parameters are reset when a compressor is pulled from the pool. HADOOP-5281 is an instance of a bug following this pattern. If the intent is to create all Gzip codecs with the same settings, then OK. > GzipCodec should read compression level etc from configuration > -------------------------------------------------------------- > > Key: HADOOP-5879 > URL: https://issues.apache.org/jira/browse/HADOOP-5879 > Project: Hadoop Core > Issue Type: Improvement > Components: io > Reporter: Zheng Shao > Attachments: hadoop-5879-5-21.patch > > > GzipCodec currently uses the default compression level. We should allow > overriding the default value from Configuration. > {code} > static final class GzipZlibCompressor extends ZlibCompressor { > public GzipZlibCompressor() { > super(ZlibCompressor.CompressionLevel.DEFAULT_COMPRESSION, > ZlibCompressor.CompressionStrategy.DEFAULT_STRATEGY, > ZlibCompressor.CompressionHeader.GZIP_FORMAT, 64*1024); > } > } > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.