[
https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713486#action_12713486
]
Amar Kamat commented on HADOOP-5649:
------------------------------------
Fredrik, the patch looks good. Few minor comments.
# Can you add 'mapred.jobtracker.plugins' to mapred-default.xml and document it
there.
# bq. LOG.warn("ServicePlugin " + p + " could not be started", t);
and
bq. LOG.warn("ServicePlugin " + p + " could not be stopped", t);
Here *p* will log junk info about the object (Object.toString()). Either we can
simply dump the exception or else define {{ServicePlugin.getName()}}.
Rest looks good.
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
