[
https://issues.apache.org/jira/browse/HADOOP-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713497#action_12713497
]
Tom White commented on HADOOP-5836:
-----------------------------------
These changes look good. A few comments
* Have you run Jets3tNativeS3FileSystemContractTest? This isn't run by default
since it needs an S3 account to test with. This serves as a good regression
test.
* There's a mixture of debug-level and info-level debugging here. How noisy is
this in practice? Shouldn't it be mainly debug, so folks can enable it when
they hit problems?
* Some of the indentation looks wrong in the patch - e.g. in
handleServiceException(S3ServiceException).
* The patch doesn't apply cleanly anymore and needs regenerating.
> Bug in S3N handling of directory markers using an object with a trailing "/"
> causes jobs to fail
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5836
> URL: https://issues.apache.org/jira/browse/HADOOP-5836
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 0.18.3
> Reporter: Ian Nowland
> Fix For: 0.21.0
>
> Attachments: HADOOP-5836-0.patch
>
>
> Some tools which upload to S3 and use a object terminated with a "/" as a
> directory marker, for instance "s3n://mybucket/mydir/". If asked to iterate
> that "directory" via listStatus(), then the current code will return an empty
> file "", which the InputFormatter happily assigns to a split, and which later
> causes a task to fail, and probably the job to fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
