[ 
https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713744#action_12713744
 ] 

Raghu Angadi commented on HADOOP-5700:
--------------------------------------

+1 for javadoc fix.

Regd throwing a runtime exception, is it really different from NPE? Wouldn't 
any runtime exception in NN indicate a bug in NN?

Can a user commad/usercode actually trigger this NPE? If yes, then it probably 
should be regular error (IOException etc) rather than a runtime exception. 

How did you notice this NPE?

> INode.getPathComponents throws NPE when given a non-absolute path
> -----------------------------------------------------------------
>
>                 Key: HADOOP-5700
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5700
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5700.txt
>
>
> If you pass a path that doesn't start with '/' to INode.getPathComponents, it 
> throws a NullPointerException. Instead it should throw 
> IllegalArgumentException to make it clear that absolute paths are required in 
> this code.
> The attached patch fixes this, clarifies, the javadoc, and adds a test case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply via email to