[
https://issues.apache.org/jira/browse/HADOOP-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated HADOOP-5698:
--------------------------------------------
Status: Patch Available (was: Open)
bq. I think it would be a better idea not to club the fixes to the existing
mapred.CombineInputFormat into this Jira. That should be addressed in a
separate Jira and the patch for this should be built on top of that.
Done by HADOOP-5759
bq. # Minor - Why is there a return 2 in run (instead of return 1 as in
existing code)
exit code is 2 if the usage was wrong
bq. CombineFileInputFormat.createRecordReader - should this just return null or
should it call super.createRecordReader
Implemented abstract method from super class to return null. commented the same
test-patch :
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 9 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
{noformat}
> Change org.apache.hadoop.examples.MultiFileWordCount to use new mapreduce api.
> ------------------------------------------------------------------------------
>
> Key: HADOOP-5698
> URL: https://issues.apache.org/jira/browse/HADOOP-5698
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5698-1.txt, patch-5698.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
