[ https://issues.apache.org/jira/browse/HADOOP-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714544#action_12714544 ]
Suresh Srinivas commented on HADOOP-5859: ----------------------------------------- # Remove commented line setting maxPacket to 1000 # {{DataStreamer.run()}} No need to set {{response}} to null, because closeResponse() called prior, sets the response to null # {{DataStreamer.run()}} code could be refactor to use closeStream() method instead of duplicating the code to close {{blockStream}}. A flag could be passed to indicate indicate end-of-block. # {{ResponseProcessor.processDataNodeError()}} could use closeStream method. > FindBugs : fix "wait() or sleep() with locks held" warnings in hdfs > ------------------------------------------------------------------- > > Key: HADOOP-5859 > URL: https://issues.apache.org/jira/browse/HADOOP-5859 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Kan Zhang > Assignee: Kan Zhang > Attachments: 5859-21.patch, 5859-22.patch, 5859-26.patch, > 5859-33.patch, 5859-4.patch, 5859-5.patch, 5859-8.patch > > > This JIRA fixes the following warnings: > SWL org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closeInternal() calls > Thread.sleep() with a lock held > TLW wait() with two locks held in > org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal() > TLW wait() with two locks held in > org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal() > TLW wait() with two locks held in > org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.writeChunk(byte[], int, int, > byte[]) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.