[
https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714618#action_12714618
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5700:
------------------------------------------------
> No, RuntimeException is an indication of a bug. And replacing one bug by
> another does not solve the problem.
As mentioned before, I don't think there is a bug in getPathComponents(..)
since the parameter is supposed to be an absolute path. Throwing
RuntimeException here indicates that the caller codes have a bug.
> ... I proposed we should also call DFSUtil.isValidName(src) ...
Yes, this is another option of fixing this.
> INode.getPathComponents throws NPE when given a non-absolute path
> -----------------------------------------------------------------
>
> Key: HADOOP-5700
> URL: https://issues.apache.org/jira/browse/HADOOP-5700
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5700.txt
>
>
> If you pass a path that doesn't start with '/' to INode.getPathComponents, it
> throws a NullPointerException. Instead it should throw
> IllegalArgumentException to make it clear that absolute paths are required in
> this code.
> The attached patch fixes this, clarifies, the javadoc, and adds a test case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
