[
https://issues.apache.org/jira/browse/HADOOP-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715636#action_12715636
]
Suresh Srinivas commented on HADOOP-5859:
-----------------------------------------
# {{DataStreamer.nextBlockOutputStream()}} unnecessary code setting {{nodes}}
to null (I see a Dead store to nodes findbugs warnings).
# nit: You can get rid of parameter to {{DataStreamer.closeStream()}} and use
{{DataStreamer.sendEndOfBlock}} instead. Simplifies understanding the cases
when end of block is sent.
# nit: {{DataStreamer.close()}} - it is a good idea to move printing the log of
sending end of block to {{DataStreamer.closeStreamer()}} method.
# nit: Move the comments added for {{DataStreamer.run()}} to the beginning of
{{DataStreamer}} class.
# nit: Capitalize {{MaxRecoveryErrorCount}}
> FindBugs : fix "wait() or sleep() with locks held" warnings in hdfs
> -------------------------------------------------------------------
>
> Key: HADOOP-5859
> URL: https://issues.apache.org/jira/browse/HADOOP-5859
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: 5859-21.patch, 5859-22.patch, 5859-26.patch,
> 5859-33.patch, 5859-35.patch, 5859-36.patch, 5859-38.patch, 5859-4.patch,
> 5859-5.patch, 5859-8.patch
>
>
> This JIRA fixes the following warnings:
> SWL org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closeInternal() calls
> Thread.sleep() with a lock held
> TLW wait() with two locks held in
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal()
> TLW wait() with two locks held in
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal()
> TLW wait() with two locks held in
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.writeChunk(byte[], int, int,
> byte[])
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
