[
https://issues.apache.org/jira/browse/HADOOP-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716882#action_12716882
]
Flavio Paiva Junqueira commented on HADOOP-5832:
------------------------------------------------
On the comments from Raghu:
* -1 on indentation. I'm seeing tabs in some included lines, and some
statements seem misplaced, like the "finally" declaration in
TestBackupNode.java;
* It is true that the patch is spread out, but most of it replaces the use of
File with URI, and touching multiple files seems necessary to add the proposed
functionality. I don't see a good way around it, so it is fine with me.
I have run the hdfs tests, and it passes all but one: Test
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
It gives me the following error:
{noformat}
Testcase: testOIV took 7.667 sec
Caused an ERROR
null
java.lang.ArrayStoreException
at java.lang.System.arraycopy(Native Method)
at java.util.Arrays.copyOf(Arrays.java:2763)
at java.util.ArrayList.toArray(ArrayList.java:305)
at
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer.initFsimage(TestOfflineImageViewer.java:127)
at
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer.testOIV(TestOfflineImageViewer.java:77)
{noformat}
Inspecting the code, we see that line 127 of the test is:
{code:title=TestOfflineImageViewer.java|borderStyle=solid}
File [] files = cluster.getNameDirs().toArray(new File[0]);
{code}
which looks like it could be caused by the changes of this patch. In fact,
without the patch, this test runs fine for me.
> Process dfs.name.edits.dirs as URI
> -----------------------------------
>
> Key: HADOOP-5832
> URL: https://issues.apache.org/jira/browse/HADOOP-5832
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Affects Versions: 0.20.0
> Reporter: Luca Telloli
> Fix For: 0.21.0
>
> Attachments: HADOOP-5832.patch
>
>
> Process the value of property dfs.name.edits.dirs as URI, to allow different
> schemes than just file. As an advantage, Java supports the constructor
> File(URI) so the transition is straightforward for files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
