[
https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717615#action_12717615
]
Jothi Padmanabhan commented on HADOOP-5938:
-------------------------------------------
Looks good. Some minor comments:
# mapred.jobcontrol.Job, use LOG instead of System.out.println to log the
exception.
# Retain the old tests.
# There is some code duplication in the test case. This probably can be
refactored.
# You could easily include a test for suspending and resuming JobControl.
# Add a test that verifies that a dependent job cannot be added to a job that
is not in the waiting state.
# The utility tests can be moved to test/mapreduce package itself, something in
line of UtilsForTests so that other tests can use them too, no?
# Minor nit -- Keep the code wrapped at 80 characters
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
