[ 
https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718411#action_12718411
 ] 

Hemanth Yamijala commented on HADOOP-5980:
------------------------------------------

Code changes look ok. We are not adding newlines to the exported environment. 
Is this OK ? 

Some comments on the test case:
- testEnvironment: The test shouldRun() should be made.
- If the test in TestMiniMRChildTask fails, we will not do cleanup operations 
like deleting the outDir. I think we should call the runTestTaskEnv method in a 
try...catch...finally block and in the finally, do cleanup.
- Do we need to check if the job execution fails ?


> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-5980
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5980
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get 
> LD_LIBRARY_PATH in their environment. The tasks should get same 
> LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to