[
https://issues.apache.org/jira/browse/HADOOP-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718799#action_12718799
]
Hemanth Yamijala commented on HADOOP-5913:
------------------------------------------
I tried to see if this is ready for a commit. But I had a few comments.
- In the commands manual, the documentation of the refreshQueues command seems
a little too terse. We should expand on it a bit more.
- In cluster_setup documentation, it appears that mapred.queue.names property
is described *after* the ACLs. This order should be reversed.
- QueueManager.isRunning() should be synchronized.
- In checkDeprecation, the checks for mapred.queue.names is using a
getStrings() with a default value, which means it will never be null. Hence, it
doesn't serve the purpose.
- Methods in Queue don't seem to need to be public.
- Should they also be synchronized ?
- The QueueState enum has a method called 'equalTo'. Why doesn't the idiomatic
'equals' apply here ?
- QueueManager.getQueueAcls() should be similarly delegated like hasAccess(),
no ?
> Allow administrators to be able to start and stop queues
> ---------------------------------------------------------
>
> Key: HADOOP-5913
> URL: https://issues.apache.org/jira/browse/HADOOP-5913
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: rahul k singh
> Assignee: rahul k singh
> Attachments: hadoop-5913-1.patch, hadoop-5913-10.patch,
> hadoop-5913-2.patch, hadoop-5913-3.patch, hadoop-5913-4.patch,
> hadoop-5913-5.patch, hadoop-5913-6.patch, hadoop-5913-7.patch,
> hadoop-5913-8.patch, hadoop-5913-9.patch
>
>
> This feature would provide functionality to stop and start queues in Hadoop
> at runtime.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
