[
https://issues.apache.org/jira/browse/HADOOP-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718999#action_12718999
]
Raghu Angadi commented on HADOOP-5832:
--------------------------------------
Luca,
Could you confirm if any of the error handling is different compared current
trunk? If there are any differences could you list them here? It is harder
reviewers alone to do this. Could you confirm that things that caused a hard
error still does and vice versa.
For e.g: {noformat}
try {
URI u = new URI(name);
// If the scheme was not declared, default to file://
// and use the absolute path of the file
if(u.getScheme() == null)
u = new URI("file://" + new File(name).getAbsolutePath());
dirs.add(u);
} catch (Exception e) {
LOG.error("Error while processing URI: " + name +
". The error message was: " + e.getMessage());
}
{noformat}
Edits and FSImage directories are very critical part of NN operation. Ignoring
error like this might not be good.
Other comments :
# Please update hdfs-default.xml for {{dfs.name.dir}}. Mainly the description
needs to be updated for new syntax.
# May be a warning when there is no schema would help get configs updated.
# Indentation "fixes" : I don't see any reason do indentation fixes far away
from actual changes for this patch. Some of these are not even fixes. A good
rule of thumb I follow is that if I have a hunk in the patch that has only
these changes, I remove it from my patch. That is easy to do. On the plus side,
you won't get 'svn blame'd for bugs around there :).
> Process dfs.name.edits.dirs as URI
> -----------------------------------
>
> Key: HADOOP-5832
> URL: https://issues.apache.org/jira/browse/HADOOP-5832
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Affects Versions: 0.20.0
> Reporter: Luca Telloli
> Fix For: 0.21.0
>
> Attachments: HADOOP-5832.patch, HADOOP-5832.patch
>
>
> Process the value of property dfs.name.edits.dirs as URI, to allow different
> schemes than just file. As an advantage, Java supports the constructor
> File(URI) so the transition is straightforward for files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
