[
https://issues.apache.org/jira/browse/HADOOP-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719382#action_12719382
]
Philip Zeyliger commented on HADOOP-6003:
-----------------------------------------
It looks like some of the patches have inconsistent usage of tabs/spaces; you
may want to clean that up.
bq. It is expected to see unit tests failing with faults in place. We might
need to develop different kind of tests to utilize fault injection in a better
way.
I think you're right on here. It seems like having a global setting for
injection probability will mostly lead to test results that are hard to grok.
Have you thought about setting up a separate package/target for tests that are
designed to interact with injected faults? Once one or two of those tests
exists, it'll be clearer whether "ant run-test-hdfs
-Dfault.probability.FSDataset=3" is the right API.
> AspectJ framework for HDFS code and tests
> -----------------------------------------
>
> Key: HADOOP-6003
> URL: https://issues.apache.org/jira/browse/HADOOP-6003
> Project: Hadoop Core
> Issue Type: Sub-task
> Affects Versions: 0.20.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6003.patch, HADOOP-6003.sh
>
>
> This subtask takes care about HDFS part of Hadoop only. Others will be added
> later as needed: it will include only new aspects development and
> modifications of build.xml file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
