[ 
https://issues.apache.org/jira/browse/HADOOP-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719746#action_12719746
 ] 

Suresh Srinivas commented on HADOOP-5724:
-----------------------------------------

Raghu based on your comment, removeINode() is removed and removeBlockFromMap() 
is used instead.

bq. depending what we do with removeINode(), it may not be necessary to change 
removeBlockFromMap(). The new implementation does a look up but does not check 
if 'info' is null.
I am not sure what you mean here. I changed removeBlockFromMap() to take Block 
instead of BlockInfo to make it a more generic method to work with both Block 
and BlockInfo. Checking for null is done in BlocksMap.removeBlock(). As regards 
to lookup, BlockMap.removeBlock() any way has to call remove() on HashMap which 
does a look up. I just optimized it such that remove is used for lookup and 
removing the entry from the map.


> Datanode should report deletion of blocks to Namenode explicitly
> ----------------------------------------------------------------
>
>                 Key: HADOOP-5724
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5724
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.21.0
>
>         Attachments: blockdel-1.patch, blockdel.patch, blockdel.patch
>
>
> Currently datanode notifies namenode newly added blocks and the blocks that 
> are corrupt. There is no explicit message from the datanode to the namenode 
> to indicate the deletion of blocks. Block reports from the datanode is the 
> only way for the namenode to learn about the deletion of blocks at a 
> datanode. With the addition of explicit request to indicate to block 
> deletion, block report interval (which is currently 1 hour) can be increased 
> to a longer duration. This reduces load on both namenode and datanodes.
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to