[ https://issues.apache.org/jira/browse/HADOOP-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719832#action_12719832 ]
Hadoop QA commented on HADOOP-2366: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410578/HADOOP-2366.patch against trunk revision 784663. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/499/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/499/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/499/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/499/console This message is automatically generated. > Space in the value for dfs.data.dir can cause great problems > ------------------------------------------------------------ > > Key: HADOOP-2366 > URL: https://issues.apache.org/jira/browse/HADOOP-2366 > Project: Hadoop Core > Issue Type: Bug > Components: conf > Reporter: Ted Dunning > Assignee: Todd Lipcon > Attachments: HADOOP-2366.patch > > > The following configuration causes problems: > <property> > <name>dfs.data.dir</name> > <value>/mnt/hstore2/hdfs, /home/foo/dfs</value> > <description> > Determines where on the local filesystem an DFS data node should store its > bl > ocks. If this is a comma-delimited list of directories, then data will be > stor > ed in all named directories, typically on different devices. Directories > that > do not exist are ignored. > </description> > </property> > The problem is that the space after the comma causes the second directory for > storage to be " /home/foo/dfs" which is in a directory named <SPACE> which > contains a sub-dir named "home" in the hadoop datanodes default directory. > This will typically cause the user's home partition to fill, but will be very > hard for the user to understand since a directory with a whitespace name is > hard to understand. > My proposed solution would be to trimLeft all path names from this and > similar property after splitting on comma. This still allows spaces in file > and directory names but avoids this problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.