[ 
https://issues.apache.org/jira/browse/HADOOP-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-6069:
--------------------------------

    Attachment: hadoop-6069.txt
                hadoop-6069-guts.txt

This patch gets rid of the dynamic loading of zlib from the native code. I've 
attached two versions, one which includes just the changes to the autoconf 
source files (-guts), and another which has the full patch to be applied to 
trunk.

This also cleans up the autotools setup a bit:
- There's no need to check HAVE_FOO_H cpp conditionals since we can just make 
configure error out at that point if they aren't found
- AC_HEADER_STDC and AC_C_CONST are considered obsolescent since any modern 
system (where one might compile Hadoop) will pass these checks
- AC_CHECK_FUNCS([memset]) was unnecessary since HAVE_MEMSET was never checked


> Remove explicit dynamic loading of libz in native code
> ------------------------------------------------------
>
>                 Key: HADOOP-6069
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6069
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6069-guts.txt, hadoop-6069.txt
>
>
> The native zlib code currently uses dlopen/dlsym to dynamically load libz. 
> This used to make sense when there was an lzo option (so you could load 
> libhadoop for lzo purposes without requiring libz as well). Now that 
> libhadoop only has zlib as an option, it makes sense to just add it as an ld 
> flag and let it be automatically loaded as a shlib dependency. I also doubt 
> that there are any distros where libz isn't required by the base system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to