[
https://issues.apache.org/jira/browse/HADOOP-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amar Kamat updated HADOOP-6055:
-------------------------------
Attachment: HADOOP-6055-v1.1.patch
Attaching a simple fix. The testcase worked because cleanup failure resulted
into cleanup delay which was intended. Adding the fix for proper cleanup
completion and a check is made in the end for job completion.
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
TestJobTrackerRestart passed on my box. Test failed without the code change.
> TestJobTrackerRestart.testJobRecoveryWithEmptyHistory doesnt test the expected
> ------------------------------------------------------------------------------
>
> Key: HADOOP-6055
> URL: https://issues.apache.org/jira/browse/HADOOP-6055
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, test
> Reporter: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: HADOOP-6055-v1.1.patch
>
>
> The test uses TestEmptyJob.CommitterWithDelayCleanup to delay cleanup. But
> the committer requires configuration property "share" to be set, which is not
> done in the test. So, cleanup fails in the test instead of getting delayed.
> Test should have an assert for Job is successful in the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
