[
https://issues.apache.org/jira/browse/HADOOP-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722234#action_12722234
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6003:
------------------------------------------------
Codes look good. Two more minor comments:
- javadoc need to be quoted by /** */. For example,
{code}
+/*
+ * This class wraps the logic around fault injection configuration file
+ * Default file is expected to be found in src/test/fi-site.xml
+ * This default file should be copied by JUnit Ant's tasks to
+ * build/test/extraconf folder before tests are ran
+ * An alternative location can be set through
+ * -Dfault.property.config=<file_name>
+ */
{code}
- Unnecessary space changes should be reverted. e.g.
{code}
--- build.xml (revision 786191)
+++ build.xml (working copy)
@@ -428,7 +428,7 @@
<fileset dir="${mapred.src.dir}" includes="mapred-default.xml"/>
</copy>
</target>
-
+
<target name="compile-hdfs-classes" depends="compile-core-classes">
<jsp-compile
uriroot="${src.webapps}/hdfs"
@@ -452,7 +452,7 @@
</jsp-compile>
<!-- Compile Java files (excluding JSPs) checking warnings -->
- <javac
+ <javac
encoding="${build.encoding}"
srcdir="${hdfs.src.dir};${build.src}"
includes="org/apache/hadoop/**/*.java"
{code}
> AspectJ framework for HDFS code and tests
> -----------------------------------------
>
> Key: HADOOP-6003
> URL: https://issues.apache.org/jira/browse/HADOOP-6003
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test
> Affects Versions: 0.20.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6003.patch, HADOOP-6003.patch, HADOOP-6003.patch,
> HADOOP-6003.patch, HADOOP-6003.patch, HADOOP-6003.patch, HADOOP-6003.patch,
> HADOOP-6003.patch, HADOOP-6003.sh, HADOOP-6003.sh
>
>
> This subtask takes care about HDFS part of Hadoop only. Others will be added
> later as needed: it will include only new aspects development and
> modifications of build.xml file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
