[ 
https://issues.apache.org/jira/browse/HADOOP-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724484#action_12724484
 ] 

Devaraj Das commented on HADOOP-4491:
-------------------------------------

On the mapreduce part of the patch,
1) TaskTracker.getIntermediateOutputDirForChild can be renamed to 
getBaseIntermediateOutputDir
2) TaskTracker.initializeJobDirs should delete stuff on all the disks, but 
should return successfully if it is able to create the path on at least one disk
3) job-id/work should be user owned?
4) Check whether the call to mkdirs(workDir) in localizeJob is required?
5) There is a spurious LOG.info(" From fComf " + 
fConf.get("mapred.local.dir")); in localizeTask. Remove it.
6) Files created within private directories don't have to have 700 permissions. 
Remove all such permissions settings (e.g., this applies to localTaskFile in 
localizeTask)
7) The work-dir in the attempt directory should be readable/writable by all 
tasks that the JVM runs (in the jvm reuse case). Currently, 
jvmManager.finalizeTaskDirs will prevent this from happening.
8) It'd be good to remove redundant calls to finalizeTaskDirs in JvmManager.
9) It will be nice to combine the APIs for creating files/directories and 
setting appropriate permissions all in one API
10) Check if the configuration setting of mapred.local.dir for the child can be 
done in the TaskTracker before launching the task (instead of the task itself 
doing that)
11) There is a spurious LOG.info in Child. Remove that or reword that.

I haven't looked at the TaskController/LinuxTaskController changes..

> Per-job local data on the TaskTracker node should have right access-control
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-4491
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4491
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: mapred, security
>            Reporter: Arun C Murthy
>            Assignee: Vinod K V
>         Attachments: HADOOP-4491-20090623-common.1.txt, 
> HADOOP-4491-20090623-mapred.1.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to