> Please review these small changes to address intermittent failures, as of > JDK-8274517. > > - Usage of jdk.test.lib.RandomFactory for reproducible random generation. > - Slightly less restrictive assertion about badParallelStreamError on L94 > (former L88). > - Verbatim copy of computeFinalSum() from j.u.s.Collectors 18. > > While these changes do not necessarily guarantee absence of intermittent > failures, the usage of jdk.test.lib.RandomFactory should at least help to pin > down specific double sequences that do not pass the test. > > There is still an inherent variability due to the use of parallel streams, > though. As double addition is not perfectly associative, even a fully known > sequence of doubles may lead to slightly different results with > parallelization.
Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] Merge branch 'master' into JDK-8274517 - 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8290/files - new: https://git.openjdk.java.net/jdk/pull/8290/files/769855cd..6035eeab Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8290&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8290&range=00-01 Stats: 154484 lines in 2948 files changed: 127735 ins; 11899 del; 14850 mod Patch: https://git.openjdk.java.net/jdk/pull/8290.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8290/head:pull/8290 PR: https://git.openjdk.java.net/jdk/pull/8290
