On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev <[email protected]> 
wrote:

> - Error will be thrown if app image is generated with another JDK version or 
> has malformed .jpackage.xml.
>  - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

-

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 339:

> 337:                 !("true".equals(appStoreStr) || 
> "false".equals(appStoreStr))) {
> 338:             return false;
> 339:         }

It makes sense to unfold this function in the ctor as we don't allow empty 
AppImageFile instances.

-------------

Changes requested by asemenyuk (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/9

Reply via email to