iris clark wrote:
Hi, Martin.
6633613: (str) StringCoding optimizations to avoid unnecessary array
copies with Charset arg
First, warning suppression:
I don't believe that StringCoding.java produces build warnings using
the default javac options. Should I assume that you're talking about
eliminating all build warnings produced using "-Xlint:all" for this
file only (not all of the String* files)?
My personal development environment includes a private build
system that recompiles all modified .java source files with
-Xlint:all. I like to remove warnings when working on a source file.
second, actual fix:
diff --git a/src/share/classes/java/lang/StringCoding.java
b/src/share/classes/java/lang/StringCoding.java
The code you modified was added _extremely_ late during jdk6
development to fix another bug. There's a regression test for that
bug. Hopefully you ran it? (Not that I expect it to fail... )
Yup.
Speaking of regression tests, you didn't include one in these diffs
and I don't see an appropriate "noreg-*" keyword in the bug. Please
resolve this. See Step 6 ofthe Guide, "Change Planning and
Guidelines" [1] for a list of possible keywords.
I've added noreg-perf.
Martin
