Am 27.06.2009 18:56, Martin Buchholz schrieb:
On Fri, Jun 26, 2009 at 10:33, Xueming Shen <xueming.s...@sun.com
<mailto:xueming.s...@sun.com>> wrote:
The latest version looks good. 2 nit comments
(1) it's reasonable to have createTempFileInSamDirectoryAs
separate out, but I would
keep the directoryOf within it. Yes, it's "clearer":-)
Done.
}
/**
- * A variant of File.getParentFile that always returns a valid
- * directory (i.e. returns new File(".") where File.getParentFile
- * would return null).
- */
- private static File directoryOf(File file) {
- File dir = file.getParentFile();
- return (dir != null) ? dir : new File(".");
- }
-
- /**
* Creates a new empty temporary file in the same directory as the
* specified file. A variant of File.createTempFile.
*/
private static File createTempFileInSameDirectoryAs(File file)
throws IOException {
- return File.createTempFile("jartmp", null, directoryOf(file));
+ File dir = file.getParentFile();
+ if (dir == null)
+ dir = new File(".");
+ return File.createTempFile("jartmp", null, dir);
}
Additional 2 cents, I more would like:
+ return File.createTempFile("jartmp", null, (dir != null ? dir :
new File(".")));
Short and clear (at least for me ;-) )
-Ulf
