> Date: Mon, 29 Jun 2009 21:39:58 +0100 > From: alan.bate...@sun.com > Xueming Shen wrote: >> ... >> >> It might be better to simply initialize the sprops.os_name to >> "Windows NT (unknown)" at >> the very beginning of the nt block and then depends on the version >> number to see if we have >> a better guess. >> >> (2)We have been doing the same exercise every time MS released a new >> os, it might be the >> time to extract this out to a "configurable" file and simple do a >> lookup based on the platform, >> verMajor, verMinor. > > It is true that we need to touch this code whenever a new edition of > Windows comes along. As it runs at startup I would be hesitant to > introduce a lookup file.
Indeed. We should be reducing the number of files we open at startup, not adding to them. - Mark
