On Tue, Jul 14, 2009 at 12:50, Xueming Shen <xueming.s...@sun.com> wrote:
> > (2) > > a) return (int)(char) uc ==uc; > > is nice:-) but I would go with the "more easy to read" > > return uc < Surrogate.UCS4_MIN; > > if it were my code. Is there a big performance gain by doing that? > That's almost, but not exactly the same - uc might be negative. (I don't know whether that can ever happen, though) My code is likely to be slightly faster than return uc < Surrogate.UCS4_MIN && uc >= 0; > b) The "buffer" version and the "array" version of generate() are not > synced. > Yikes! Good catch. Fixed - webrev regenerated. Thanks, Martin
