2009/10/15 Michael McMahon <[email protected]>: > It doesn't seem right to filter out arbitrary environment variables > like that (inside ProcessEnvironment). Sorry, I haven't been following this > issue closely, > but is it not possible to unset this variable somewhere else? >
I concur. That's a nasty hack that's going to create an artificial difference between the native environment and the environment as seen from Java. > - Michael. > > Alan Bateman wrote: >> >> Martin, Michael - have either of you looked at the filtering that they are >> proposing to add to ProcessEnvironment? >> >> >> Anthony Petrov wrote: >>> >>> Hello, >>> >>> Please review the next version of the fix contributed by Damjan >>> Jovanovic: >>> >>> RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 >>> There you can also find some latest comments regarding the fix. >>> >>> webrev: >>> http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.1/ >>> >>> Since the patch includes changes to the >>> src/solaris/classes/java/lang/ProcessEnvironment.java, I'm >>> CC'ing the Core Libs alias to review the changes in that file. >>> >>> >>> From AWT perspective, the changes look good to me. >>> >>> -- >>> best regards, >>> Anthony >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
