Bob Lee wrote:
:
Should we use an enum for the flush strategies? It would help separate
them from the compression strategies, and it would make the new method
easier to use because it would be obvious at compile time which values
you can pass in (as opposed to allowing any random int).
Also, we could add a note about how alternate flush strategies can
negatively affect compatibility with tools like WinZip.
This is a tough one. Enums have clear advantages but it isn't always
clear if it is the right thing (from a consistency point of view) when
updating APIs that date from before enums. In this case it probably
isn't too bad in that many applications use DeflaterOutputStream rather
than using Deflater directly.
I wasn't aware of any compatibility issues with WinZip (Sherman, do
might know about this?). The main motive, as you probably know, was the
compressed network stream rather than zip files.
-Alan.
