Christian Thalinger wrote:
On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote:
Hello.
Please review my fix for
6908131 Pure Java implementations of StrictMath.floor(double)
&StrictMath.ceil(double)
http://cr.openjdk.java.net/~darcy/6908131.0/
I've asked Doug Priest, one of Sun's numerical experts, to review the
floor/ceil algorithm and testing. I've incorporated his feedback and he
has approved those aspects of the changes. The JDK integration has not
yet been looked over.
Not a review, but did you think about implementing the whole FDLIBM in
Java, as done here:
http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html
Yes, porting FDLIBM to Java has been an oft-delayed "nice to have"
project of mine. It is not obvious from looking at my ceil/floor code,
but it started with the FDLIBM versions of those algorithms. The tests
are new and greatly outnumber the code changes, as it typical in this
line of work :-) I think getting an all-java StrictMath library would
be best done as a series of small batches so floor/ceil could be a start.
-Joe
