Thanks for the review.
The Z_SYNC_FLUSH is supposed to fully replace the Z_PARTIAL_FLUSH.
We concluded last round that Z_SYNC_FLUSH is enough for the "high-level"
DOS, as well as the GZIPOS, use Deflater directly if more needed. I
hope you
are not suggesting we go back to redo the flush to int.
Took a quick look at 1.2.5, don't see anything make it attractive for us to
"upgrade" again.
Sherman
Martin Buchholz wrote:
zlib 1.2.5 is out!
Quite notably, there are now more flush modes
and the comment claiming that Z_PARTIAL_FLUSH
will be removed has been removed!
As I recall saying in a previous email,
we should support Z_PARTIAL_FLUSH at least
because the ssh protocol requires it.
I think the flush parameter should be an int.
----
invocatin => invocation
+ * if {...@code true} invocatin of the inherited
Martin
On Wed, May 12, 2010 at 15:51, Xueming Shen <xueming.s...@oracle.com> wrote:
Martin,
Would you please help review the change for
4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH
http://cr.openjdk.java.net/~sherman/4813885/webrev
It appears people want to have the same flush option in GZIPOutputStream as
the
one we provided in DeflaterOutputStream for #4206909 a while ago, the webrev
for
4206909 is at
http://cr.openjdk.java.net/~sherman/4206909/webrev
Thanks,
-Sherman
