Xueming Shen wrote:
Alan,
Can you help review?
(1)TestUTF8
This one is no longer reproducible, it passes on all platforms
during the last several jprt runs.
(2)FindDecoderBugs
The only possible cause of its failure on a particular platform is
timeout, this test takes long cpu time
on slow machine. I tweak it a little, it runs about 30% faster now.
It passes the last several jprt runs
on all platforms.
(3) TestX11CNS
This test is not really necessary (it is useful when migration to
new implementation) but I modified
it to run and pass anyway.
http://cr.openjdk.java.net/~sherman/test_cs/webrev/
Speeding up FindDecoderBugs is good. Is the static equals method that
you've added to the "Infrastructure" section used?
TestX11CNS.getCharsets might consume an exception that we might want to
see. Would it be better if it only returned null if
UnsupportedCharsetException is thrown, and maybe have the test fail if
there is another problem.
Do you have cycles to take a pass over the sun/nio/cs tests to see if
they could run in samevm mode? I think they are in batch jdk_nio3 at the
moment and that test target currently runs in othervm mode.
-Alan.
