On Tue, Aug 3, 2010 at 10:16, Kelly O'Hair <[email protected]> wrote:
> > On Aug 2, 2010, at 2:52 PM, Martin Buchholz wrote: > > Hi Chris (or others), > > Here's a fix for a little bug I introduced in jdk7-b94 > > http://bugs.sun.com/view_bug.do?bug_id=6955504 > 6955504: (str) String[Builder/Buffer].append(char[],int,int) throws > OutOfMemoryError in b94 > http://cr.openjdk.java.net/~martin/webrevs/openjdk7/oome2aioobe/<http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk7/oome2aioobe/> > > I couldn't resist sneaking in a little optimization. > > I'm a little disappointed that I broke a JCK test, but that this was not > noticed by openjdk QA until several builds later. I'm thinking it's part of > the job of integrators to ensure __NO__REGRESSIONS__ and that includes jck > tests (which are much easier for integrators to run than for external > contributors). > > > The JCK tests are NO easier to run for anyone, it only gets easier if you > have repeatedly run it over and over. > Well, yes, but since running tests repeatedly is part of an integrator's job, that means it's easier for them. > > And it is impossible to guarantee no regressions given the time and > resources available to an integrator. > Avoiding regressions is a shared responsibility we all have. > > In this case, we need to figure out how to get regular runs of JCK into the > integration process. > > Running JCK tests were part of the TL integration process when I left Sun. On my watch, when I was TL integrator, I guaranteed __NO__REGRESSIONS__ (on a defined set of tests that included the core library jck tests). Martin > -kto > > > > Martin > > >
